Repository navigation
[skills] Make local SDK validation the default for agents - #13006
Merged
Merged
Conversation
The test skill called full SDK builds slow and asked agents whether to skip full-build tests when the local SDK was missing. This encouraged agents to defer validation to CI instead of testing changes locally. Require preparing missing SDKs and running relevant local tests before pushing. Preserve explicit user limits and concrete environment blockers, and correct the test assembly framework examples. Co-authored-by: Copilot App <[email protected]>
simonrozsival
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
These documentation-only changes have no blocking issues and do not alter build behavior.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Makes local SDK builds and relevant tests the default validation workflow for .NET for Android agents.
Changes:
- Requires local validation and reporting actual commands, outcomes, and blockers while preserving documented exceptions.
- Updates test assembly examples from
net9.0tonet10.0.
| File | Description |
|---|---|
.github/skills/tests/SKILL.md |
Replaces build-or-skip guidance with local build and test expectations. |
.github/copilot-instructions.md |
Adds validation requirements and refreshes test commands. |
Check only the requested configuration and require an executable dotnet, matching the launcher prerequisite instead of accepting either SDK. Co-authored-by: Copilot App <[email protected]> Co-authored-by: Copilot <[email protected]>
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Oct 5, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The selected-configuration SDK check and net10.0 test examples match the actual wrapper/project contracts. The local-validation policy preserves standalone and read-only modes, explicit user/environment limits, and documentation-only exceptions; no high-confidence blocker remains.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test skill described full SDK builds as slow and explicitly asked
agents whether to build or skip full-build tests when the local SDK was
missing. This encouraged agents to avoid local validation and defer it
to CI, even when the hardware can comfortably handle the build.
Update the main Copilot instructions and test skill to make local builds
and relevant host/device tests the default before pushing or opening a
PR. Prepare missing SDKs, rebuild after source changes, and report actual
commands and outcomes. Keep documentation-only exceptions, explicit
user limits, and concrete environment blockers. Also update the test
assembly examples from net9.0 to the current net10.0 framework.
Validation:
git diff --checkpassed. SDK builds and unit/device testswere not run because these changes only affect agent documentation.
No linked issue.
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include: