Repository navigation
[build] Generate separate .binlog files for tests. - #2001
Merged
Merged
Conversation
jonpryor
force-pushed
the
jonp-tests-binlog
branch
from
July 25, 2018 20:06
911d2de to
4140d59
Compare
Context: dotnet#1792 Context: 987a05f Commit 987a05f updated the "normal" build log process, as used by Jenkins/etc., so that Console output received "normal" build verbosity messages, while MSBuild `.binlog` files would be generated so that "diagnostic" build logs could be produced "later," as necessary. Unfortunately, commit 987a05f didn't update unit test builds. Consequently, `make run-apk-tests`/etc. would emit *diagnostic* build logs to the Console, meaning instead of the previous ~1GB log file, we instead had a "mere" ~400MB instead. Update test execution so that they follow the spirit of 987a05f: `.binlog` files for diagnostic output, with "normal" output printed to the console, resulting in smaller Jenkins log files.
jonpryor
force-pushed
the
jonp-tests-binlog
branch
from
July 26, 2018 01:23
4140d59 to
d9d4261
Compare
Contributor
Author
jonathanpeppers
approved these changes
Jul 26, 2018
dellis1972
approved these changes
Aug 2, 2018
Contributor
Author
Undoubtedly true, but the mentioned https://github.com/xamarin/java.interop/blob/8ee34a353f35021e8639bec3c4b64415462e8b43/Makefile#L110 For simplicity and sanity's sake, that's outside the scope of this PR. :-) The Java.Interop build steps are the only instances of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #1792
Context: 987a05f
Commit 987a05f updated the "normal" build log process, as used by
Jenkins/etc., so that Console output received "normal" build verbosity
messages, while MSBuild
.binlogfiles would be generated so that"diagnostic" build logs could be produced "later," as necessary.
Unfortunately, commit 987a05f didn't update unit test builds.
Consequently,
make run-apk-tests/etc. would emit diagnostic buildlogs to the Console, meaning instead of the previous ~1GB log file, we
instead had a "mere" ~400MB instead.
Update test execution so that they follow the spirit of 987a05f:
.binlogfiles for diagnostic output, with "normal" output printed tothe console, resulting in smaller Jenkins log files.