Repository navigation
[Xamarin.Android.Build.Tasks] Add CopyResource items to FileWrites. - #2288
Merged
Merged
Conversation
Not quite sure how we ever got away with this. As part of the build process we extract from `EmbeddedResource` a bunch of `.java` files into the intermediate directory. These are used for a number of things like multidex and bootstrapping mono. For some reason we NEVER added those to the `FileWrites` group. So there is a good chance these files will get deleted by an incremental clean. This was picked up by a unit test in monodroid which deals with fast deployment.
dellis1972
force-pushed
the
filewritescopyresource
branch
from
October 11, 2018 14:34
4ffe636 to
6d45402
Compare
| // change one of the properties (say AotAssemblies) | ||
| // do another build. it should NOT hose the resource directory. | ||
| var path = Path.Combine ( "temp", TestName ); | ||
| var proj = new XamarinAndroidApplicationProject () { |
Member
There was a problem hiding this comment.
Whoops I think this one should be the new XamarinFormsAndroidApplicationProject.
jonathanpeppers
approved these changes
Oct 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not quite sure how we ever got away with this. As part
of the build process we extract from
EmbeddedResourcea bunch of
.javafiles into the intermediate directory.These are used for a number of things like multidex and
bootstrapping mono. For some reason we NEVER added those
to the
FileWritesgroup. So there is a good chance thesefiles will get deleted by an incremental clean.
This was picked up by a unit test in monodroid which
deals with fast deployment.