Repository navigation
[Xamarin.Android.Build.Tasks] Fix Aar directory resolution. (#2424) - #2556
Merged
Merged
Conversation
) * [Xamarin.Android.Build.Tasks] Fix Aar directory resolution. Fixed dotnet#2408 As part of the speed up process when extracting resources from assemblies and Aar files, we dont re-extract if the stamp file is newer than the assembly. The problem with that was in the case of Aar files we were NOT adding the `res` or `asset` directories to the list of resolved directories when we skipped extraction. As a result we got less `res` directories on a second build. This commit fixes that. * Add Unit Test * Fix Compile Error
Contributor
Author
|
The failure: The probable fix? Also cherry-pick 02c07ed? (...and any others?) @jonathanpeppers: Thoughts? Do we even want 02c07ed in d15-9? |
jonathanpeppers
left a comment
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
I think 02c07ed is too risky to put in an SR.
I think we can get this one to work without it, though.
The usage of `ITaskItem` and item metadata isn't needed on d15-9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2408
As part of the speed up process when extracting resources
from assemblies and Aar files, we dont re-extract if
the stamp file is newer than the assembly.
The problem with that was in the case of Aar files we
were NOT adding the
resorassetdirectories tothe list of resolved directories when we skipped extraction.
As a result we got less
resdirectories on a secondbuild.
This commit fixes that.
Add Unit Test
Fix Compile Error