Skip to content

[Mono.Android] Make protected constants interfaces public. - #5897

Merged
jonpryor merged 1 commit into
mainfrom
sealed-interfaces
May 3, 2021
Merged

jonpryor merged 1 commit into
mainfrom
sealed-interfaces

Conversation

@jpobst

@jpobst jpobst commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

Fixes #5868.

These interfaces contain constants that we are pointing users to now that we can support them via DIM. However in Java they are protected interfaces in sealed classes. C# prevents users from accessing protected types inside a sealed type, so users can't actually use these members.

This commit uses metadata to make these interfaces public so their members can be used.

Android.Provider.CalendarContract/IAttendeesColumns
Android.Provider.CalendarContract/ICalendarAlertsColumns
Android.Provider.CalendarContract/ICalendarCacheColumns
Android.Provider.CalendarContract/ICalendarColumns
Android.Provider.CalendarContract/ICalendarSyncColumns
Android.Provider.CalendarContract/IColorsColumns
Android.Provider.CalendarContract/IEventDaysColumns
Android.Provider.CalendarContract/IEventsColumns
Android.Provider.CalendarContract/IExtendedPropertiesColumns
Android.Provider.CalendarContract/IRemindersColumns
Android.Provider.CalendarContract/ISyncColumns
Android.Provider.ContactsContract/IBaseSyncColumns
Android.Provider.ContactsContract/CommonDataKinds/ICommonColumns
Android.Provider.ContactsContract/IContactNameColumns
Android.Provider.ContactsContract/IContactOptionsColumns
Android.Provider.ContactsContract/IContactStatusColumns
Android.Provider.ContactsContract/IDataColumns
Android.Provider.ContactsContract/IDataUsageStatColumns
Android.Provider.ContactsContract/IDeletedContactsColumns
Android.Provider.ContactsContract/IGroupsColumns
Android.Provider.ContactsContract/IPhoneLookupColumns
Android.Provider.ContactsContract/IPresenceColumns
Android.Provider.ContactsContract/IRawContactsColumns
Android.Provider.ContactsContract/ISettingsColumns
Android.Provider.ContactsContract/IStatusColumns
Android.Provider.ContactsContract/IStreamItemPhotosColumns
Android.Provider.ContactsContract/IStreamItemsColumns
Android.Provider.ContactsContract/ISyncColumns

@jpobst
jpobst requested a review from jonpryor as a code owner April 30, 2021 19:53
@jonpryor
jonpryor merged commit 0e2321d into main May 3, 2021
@jonpryor
jonpryor deleted the sealed-interfaces branch May 3, 2021 19:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android.Provider.CalendarContract.IEventsColumns should be public (to be able to use constants)

2 participants