Repository navigation
Bump to JamesNK/Newtonsoft.Json@ae9fe44e [13.0.1] - #6090
Merged
Merged
Conversation
jonpryor
force-pushed
the
jonp-bump-newtonsoft.json-13.0.1
branch
from
July 15, 2021 01:30
df80a73 to
42edc68
Compare
dellis1972
reviewed
Jul 15, 2021
| <PackageReference Include="ILRepack" Version="2.0.18" /> | ||
| <PackageReference Include="Irony" Version="1.1.0" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="12.0.3" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.1" /> |
Contributor
There was a problem hiding this comment.
Can we unify these version numbers like we do for NuGet and LibZipSharp? So we only need to change them in one place?
Contributor
Author
There was a problem hiding this comment.
Partly; I don't see how to "reasonably" get PackagingTest.cs to use $(NewtonsoftJsonPackageVersion), but all the other uses have been updated.
Member
There was a problem hiding this comment.
We might not necessarily need to keep PackagingTest updated. It's probably just as helpful to be testing old NuGets for compatibility as the newest ones.
jonpryor
force-pushed
the
jonp-bump-newtonsoft.json-13.0.1
branch
from
July 15, 2021 16:11
42edc68 to
8bec0f7
Compare
Changes: JamesNK/Newtonsoft.Json@12.0.3...13.0.1 * JamesNK/Newtonsoft.Json@ae9fe44e: Remove compiler package and update sourcelink (dotnet#2498) * JamesNK/Newtonsoft.Json@8ef66218: Remove prerelease for 13.0.1 * JamesNK/Newtonsoft.Json@11331f50: Update SDK to 5.0.200 (dotnet#2495) * JamesNK/Newtonsoft.Json@c7e8abc0: Update to 13.0.1-beta2 * JamesNK/Newtonsoft.Json@1745d7c1: Fix JTokenWriter when writing comment to an object (dotnet#2493) * JamesNK/Newtonsoft.Json@583eb120: Fix missing error when deserializing JToken with a contract type mismatch (dotnet#2494) * JamesNK/Newtonsoft.Json@b6dc05be: Change MaxDepth default to 64 (dotnet#2473) * JamesNK/Newtonsoft.Json@15525f1c: Fix JsonWriter.WriteToken to allow null with string token (dotnet#2472) * JamesNK/Newtonsoft.Json@926d2f0f: Enable embed untracked sources (dotnet#2471) * JamesNK/Newtonsoft.Json@0a56633b: Fixes dotnet#2372 - variable typos (dotnet#2465) * JamesNK/Newtonsoft.Json@5a35c77d: Update version to 13.0.1 (dotnet#2463) * JamesNK/Newtonsoft.Json@7e77bbe1: Change JsonReader and JsonSerializer default max depth to 128 (dotnet#2462) * JamesNK/Newtonsoft.Json@42139ea6: Add JsonSelectSettings and regex timeout * JamesNK/Newtonsoft.Json@95a6eb3a: jpath regex timeout support added for a single regex expression, global umbrella for all regex calls, and support for allowing regex calls to get compiled if necessary * JamesNK/Newtonsoft.Json@1403f5d3: Fix serializing nullable struct dictionaries (dotnet#2452) * JamesNK/Newtonsoft.Json@60be32f4: Use naming strategy when deserializing dictionary enum keys (dotnet#2448) * JamesNK/Newtonsoft.Json@ff5ffb28: Copy annotations when cloning elements (dotnet#2442) * JamesNK/Newtonsoft.Json@0cf47a46: Missing nullability annotation (dotnet#2438) * JamesNK/Newtonsoft.Json@6795ca55: Fixed tests to work in Moscow, Russia UTC+3 timezone. (dotnet#2416) * JamesNK/Newtonsoft.Json@c918ca86: Code Typo Fix: Universial => Universal (dotnet#2383) * JamesNK/Newtonsoft.Json@c298f3d6: Fix typo in SerializeTypeNameHandling sample (dotnet#2428) * JamesNK/Newtonsoft.Json@a222c8b6: Update to net50 and fix warnings (dotnet#2424) * JamesNK/Newtonsoft.Json@666d9760: Fix wrong define is used in StringUtils.ToLower() (dotnet#2304) * JamesNK/Newtonsoft.Json@a31156e9: Update NullValueHandlingIgnore.aml (dotnet#2226) * JamesNK/Newtonsoft.Json@936acbf6: Update version to 13.0.1-beta and remove portable builds (dotnet#2228) * JamesNK/Newtonsoft.Json@9be95e0f: Do not treat ignored field as missing member when deserializing from overriden json constructor (dotnet#2224) The `PackagingTest.NetStandardReferenceTest()` test is updated, as the list of implicitly referenced assemblies changed: * `Microsoft.CSharp.dll` is no longer referenced * `System.Data.dll` is now referenced. It appears that the primary cause of this change is that with `Newtonsoft.Json` 12.0.3, the .NET Standard 1.3-profile assemblies were included into the app, while with 13.0.1, the .NET Standard-2.0 profile assemblies are instead used.
jonpryor
force-pushed
the
jonp-bump-newtonsoft.json-13.0.1
branch
from
July 16, 2021 01:16
8bec0f7 to
d5c65e2
Compare
jonathanpeppers
approved these changes
Jul 16, 2021
jonathanpeppers
left a comment
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
LGTM if the tests end up green.
dellis1972
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: JamesNK/Newtonsoft.Json@12.0.3...13.0.1
AndroidSdkBuildToolsVersionis not exported in binding projects #2452)