Skip to content

com.google.android.material-1.1.0-rc1 error on build #56

Closed
Closed
com.google.android.material-1.1.0-rc1 error on build#56
Assignees
moljac

Description

@ibryskin
ibryskin
opened on Feb 17, 2020

Need to add these lines to com.google.android.material/material/transforms/Metadata.xml for 1.1.0-rc1:

<remove-node path="/api/package[@name='com.google.android.material.button']/interface[@name='MaterialButton.OnPressedChangeListener']" />
<remove-node path="/api/package[@name='com.google.android.material.datepicker']/interface[@name='MaterialCalendar.OnDayClickListener']" />
<remove-node path="/api/package[@name='com.google.android.material.bottomappbar']/interface[@name='BottomAppBar.AnimationListener']" />

Activity

  1. moljac commented on Feb 17, 2020

    @moljac
    moljac
    on Feb 17, 2020
    Contributor

    @ibryskin
    Do you have minimal repro sample for this issue, please?

    I will add those for now, but I don't like removing nodes, so sample would help me checking the root cause of the issue.

  2. moljac
    self-assigned this
    on Feb 17, 2020
  3. moljac
    added
    investigating
    on Feb 17, 2020

  4. ibryskin commented on Feb 18, 2020

    @ibryskin
    ibryskin
    on Feb 18, 2020
    Author

    Here's a sample. Building this project failed with these errors (with 1.1.0-rc1):

    JAVAC0000:  error: AnimationListener is not public in BottomAppBar; cannot be accessed from outside package
JAVAC0000:  error: OnPressedChangeListener is not public in MaterialButton; cannot be accessed from outside package
JAVAC0000:  error: OnDayClickListener is not public in MaterialCalendar; cannot be accessed from outside package

    Test56.zip

  5. moljac commented on Feb 18, 2020

    @moljac
    moljac
    on Feb 18, 2020
    Contributor

    @ibryskin
    Thanks for the repro sample.

    Seems like I'll have to tweak accessibility (public) for those interfaces. Not sure yet.

    The reason I'm reluctant to remove-node is that in the future with C# 8 will have default method implementations in the interfaces. Removing node is for me last option, but I do that too when I'm forced to.

  6. Codelisk commented on Feb 19, 2020

    @Codelisk
    Codelisk
    on Feb 19, 2020

    Workaround for that in the meantime?

  7. moljac commented on Feb 19, 2020

    @moljac
    moljac
    on Feb 19, 2020
    Contributor

    @hudait
    Build it yourself or wait DevOps builds to be finished (matter of hours)

  8. moljac commented on Feb 24, 2020

    @moljac
    moljac
    on Feb 24, 2020
    Contributor

    @ibryskin

    Did rc2 resolve this issue? Please provide some feedback

  9. moljac commented on Feb 24, 2020

    @moljac
    moljac
    on Feb 24, 2020
    Contributor

    My local tests show that rc2 solved this problem

  10. ibryskin commented on Feb 25, 2020

    @ibryskin
    ibryskin
    on Feb 25, 2020
    Author

    I confirm that problem is solved. rc2 is building and working fine. Thank you.

  11. moljac commented on Feb 26, 2020

    @moljac
    moljac
    on Feb 26, 2020
    Contributor

    OK. Closing this one!

  12. moljac
    closed this as completedon Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions