Skip to content

DataBinding artifacts - #244

Merged
moljac merged 2 commits into
masterfrom
databinding-viewbinding
Jan 25, 2021
Merged

DataBinding artifacts#244
moljac merged 2 commits into
masterfrom
databinding-viewbinding

Conversation

@moljac

@moljac moljac commented Jan 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Support Libraries Version (eg: 23.3.0):

AndroidX

  • androidx.databinding.databinding-adapters - 4.1.2

  • androidx.databinding.databinding-common - 4.1.2

  • androidx.databinding.databinding-runtime - 4.1.2

  • androidx.databinding.viewbinding - 4.1.2

Does this change any of the generated binding API's?

yes. New artifacts.

Describe your contribution

Bindings of new DataBinding artifacts

See related issues:

#243

dotnet/android#3853

@moljac moljac self-assigned this Jan 24, 2021
@moljac
moljac marked this pull request as draft January 24, 2021 18:35
This was referenced Jan 24, 2021
Closed
Closed
@moljac

moljac commented Jan 25, 2021

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 25, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@moljac
moljac requested a review from jpobst January 25, 2021 11:58
@4brunu

4brunu commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

One question,
this is the dependency tree of ViewBinding

+--- androidx.databinding:viewbinding:4.1.2
|    \--- androidx.annotation:annotation:1.0.0 -> 1.1.0

and of DataBinding

+--- androidx.databinding:databinding-common:4.1.2
+--- androidx.databinding:databinding-runtime:4.1.2
        |    +--- androidx.databinding:viewbinding:4.1.2
        |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.1.0
        |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.2.0
        |    |    +--- androidx.lifecycle:lifecycle-common:2.2.0
        |    |    |    \--- androidx.annotation:annotation:1.1.0
        |    |    +--- androidx.arch.core:core-common:2.1.0
        |    |    |    \--- androidx.annotation:annotation:1.1.0
        |    |    \--- androidx.annotation:annotation:1.1.0
        |    +--- androidx.collection:collection:1.0.0 -> 1.1.0
        |    |    \--- androidx.annotation:annotation:1.1.0
        |    \--- androidx.databinding:databinding-common:4.1.2
+--- androidx.databinding:databinding-adapters:4.1.2
        |    +--- androidx.databinding:databinding-common:4.1.2
        |    \--- androidx.databinding:databinding-runtime:4.1.2

Is this configured in the Nuget packages created in this PR?

@moljac

moljac commented Jan 25, 2021

Copy link
Copy Markdown
Contributor Author

@4brunu

Is this configured in the Nuget packages created in this PR?

I hope so. This is artifact dependency tree. I don't have Nuget dependency tree.

Binderator tool does that. Yes it has some limitations and I work on tooling to enhance it. (not only dependency tree, but more)

@4brunu

4brunu commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

Thanks for the explanation 🙂
Looking forward to use this package 👍

@moljac
moljac marked this pull request as ready for review January 25, 2021 17:31
@moljac
moljac merged commit 16b02ae into master Jan 25, 2021
@moljac
moljac deleted the databinding-viewbinding branch January 25, 2021 17:31
@SourceSurfer

SourceSurfer commented Feb 16, 2023

Copy link
Copy Markdown

Hello. Could you write an example using Xamarin.AndroidX.DataBinding.ViewBinding 7.4.0.1,
many times tried to generate binding class but nothing was generated, and didnt show any error, just build succeeded.
I tried to find any information on the internet, but found just this
https://developer.android.com/topic/libraries/data-binding/generated-binding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jpobst jpobst jpobst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@moljac moljac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moljac @4brunu @SourceSurfer @jpobst