Repository navigation
Allow migration to continue when symbols are bad - #98
Merged
Merged
Conversation
moljac
reviewed
May 4, 2020
| { | ||
| var types = def.MainModule.GetTypeReferences(); | ||
| Assert.Empty(types.Where(t => | ||
| (t.FullName.StartsWith("Android.Support.") || t.FullName.StartsWith("Android.Arch.")) && |
Contributor
There was a problem hiding this comment.
In case someone adds Material. Do we need to add it in the condition?
Member
Author
There was a problem hiding this comment.
Yeah. Not the best of tests...
Let me extract this logic into a function that can be reused. I'll keep it manual for more control for now.
moljac
approved these changes
May 4, 2020
| // just ignore all symbols, there is nothing that can be done about bad symbols | ||
| readerParams.ReadSymbols = false; | ||
| return AssemblyDefinition.ReadAssembly(path, readerParams); | ||
| } |
Member
There was a problem hiding this comment.
This looks the same we've been using: https://github.com/xamarin/java.interop/blob/377c4c7ab50d1f25082c7079214b8075eb25de35/src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil/DirectoryAssemblyResolver.cs#L144-L172
We use this DirectoryAssemblyResolver any time we use Mono.Cecil during Xamarin.Android's build.
jonathanpeppers
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow migration to continue when symbols are bad.
Fixes #38
Fixes #8
Fixes #79
Fixes #93