Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[ARM/Linux] Fix inconsistency between GetHasCode and Equals - #13513

Merged
jkotas merged 1 commit into
dotnet:masterfrom
parjong:fix/SecureDelegate_GetHashCode
Aug 22, 2017
Merged

jkotas merged 1 commit into
dotnet:masterfrom
parjong:fix/SecureDelegate_GetHashCode

Conversation

@parjong

@parjong parjong commented Aug 22, 2017 •

Copy link
Copy Markdown

MulticastDelegate.Equals considers Secure/Wrapper delegates (when _invocationList is Delegate), but the corresponding GetHashCode does not take into account Secure/Wrapper delegates.

This inconsistency results in #13160.

This commit revises the implementation of GetHashCode to fix #13160.

@parjong

parjong commented Aug 22, 2017

Copy link
Copy Markdown
Author

@jkotas @janvorli Could you please take a look? I'm not sure whether this fix is correct, or not.

@parjong parjong changed the title Fix inconsistency between GetHasCode and Equals [ARM/Linux] Fix inconsistency between GetHasCode and Equals Aug 22, 2017

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas
jkotas merged commit 8b7dcb5 into dotnet:master Aug 22, 2017
@parjong
parjong deleted the fix/SecureDelegate_GetHashCode branch August 22, 2017 22:12
@karelz karelz modified the milestone: 2.1.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ARM32] Different HashCode on the same virtual method

4 participants