Generated files (e.g, Java.Interop.__TypeRegistrations.cs) should mark themselves as auto-generated #1051

Activity

1. Youssef1313

   added

   needs-triage

   on Oct 15, 2022
2. Youssef1313

   assigned

   jpobst

   on Oct 15, 2022
3. jpobst

   transferred this issue fromdotnet/androidon Oct 15, 2022
4. jpobst

   added this to the 8.0.0 milestone on Oct 15, 2022
5. jpobst

   added

   enhancementProposed change to current functionalityProposed change to current functionality

   generatorIssues binding a Java library (generator, class-parse, etc.)Issues binding a Java library (generator, class-parse, etc.)

   and removed

   needs-triage

   on Oct 15, 2022
6. jpobst commented on Oct 18, 2022

   

   jpobst

   on Oct 18, 2022

   Contributor

   More actions

   Some examples of what a regular console .NET 6 program generates:

   • .NETCoreApp,Version=v6.0.AssemblyAttributes.cs:

   // <autogenerated />
   using System;
   ...

   • {application}.AssemblyInfo.cs:

   //------------------------------------------------------------------------------
   // <auto-generated>
   //     This code was generated by a tool.
   //     Runtime Version:4.0.30319.42000
   //
   //     Changes to this file may cause incorrect behavior and will be lost if
   //     the code is regenerated.
   // </auto-generated>
   //------------------------------------------------------------------------------
   using System;
   ...

   Using the longer version could also help with issues like dotnet/android#7449.
7. jpobst commented on Oct 18, 2022

   

   jpobst

   on Oct 18, 2022

   Last edited by jpobst

   Contributor

   More actions

   Can you post a Java.Interop.__TypeRegistrations.cs that demonstrates the CA1825 warning? It looks like all the arrays should have content in them, unless your binding library doesn't bind any types or something? Or maybe all the types it binds are static?

   Example:

   		public static void RegisterPackages ()
   		{
   #if MONODROID_TIMING
   			var start = DateTime.Now;
   			Android.Util.Log.Info ("MonoDroid-Timing", "RegisterPackages start: " + (start - new DateTime (1970, 1, 1)).TotalMilliseconds);
   #endif // def MONODROID_TIMING
   			Java.Interop.TypeManager.RegisterPackages (
   					new string[]{
   						"com/google/common/flogger",
   						"com/google/common/flogger/backend",
   						"com/google/common/flogger/context",
   						"com/google/common/flogger/parameter",
   						"com/google/common/flogger/parser",
   						"com/google/common/flogger/util",
   					},
   					new Converter<string, Type?>[]{
   						lookup_com_google_common_flogger_package,
   						lookup_com_google_common_flogger_backend_package,
   						lookup_com_google_common_flogger_context_package,
   						lookup_com_google_common_flogger_parameter_package,
   						lookup_com_google_common_flogger_parser_package,
   						lookup_com_google_common_flogger_util_package,
   					});
   #if MONODROID_TIMING
   			var end = DateTime.Now;
   			Android.Util.Log.Info ("MonoDroid-Timing", "RegisterPackages time: " + (end - new DateTime (1970, 1, 1)).TotalMilliseconds + " [elapsed: " + (end - start).TotalMilliseconds + " ms]");
   #endif // def MONODROID_TIMING
   		}
8. Youssef1313 commented on Oct 18, 2022

   

   Youssef1313

   on Oct 18, 2022

   MemberAuthor

   More actions

   @jpobst This is what I'm seeing:

   using System;
   using System.Collections.Generic;
   using Android.Runtime;
   
   namespace Java.Interop {
   
   	partial class __TypeRegistrations {
   
   		public static void RegisterPackages ()
   		{
   #if MONODROID_TIMING
   			var start = DateTime.Now;
   			Android.Util.Log.Info ("MonoDroid-Timing", "RegisterPackages start: " + (start - new DateTime (1970, 1, 1)).TotalMilliseconds);
   #endif // def MONODROID_TIMING
   			Java.Interop.TypeManager.RegisterPackages (
   					new string[]{
   					},
   					new Converter<string, Type>[]{
   					});
   #if MONODROID_TIMING
   			var end = DateTime.Now;
   			Android.Util.Log.Info ("MonoDroid-Timing", "RegisterPackages time: " + (end - new DateTime (1970, 1, 1)).TotalMilliseconds + " [elapsed: " + (end - start).TotalMilliseconds + " ms]");
   #endif // def MONODROID_TIMING
   		}
   
   #if NET5_0_OR_GREATER
   		[System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage ("Trimming", "IL2057")]
   #endif
   		static Type Lookup (string[] mappings, string javaType)
   		{
   			var managedType = Java.Interop.TypeManager.LookupTypeMapping (mappings, javaType);
   			if (managedType == null)
   				return null;
   			return Type.GetType (managedType);
   		}
   	}
   }
9. jonpryor

   closed this as completedin #1052on Oct 20, 2022
10. jonpryor

    added a commit that references this issue on Oct 20, 2022

    [generator] Mark generated .cs files as generated (#1052)

    ...

    1720628
11. jonpryor

    added a commit that references this issue on Nov 1, 2022

    Bump to xamarin/Java.Interop/main@5318261 (#7502)

    ...

    6573c37
12. github-actions

    locked and limited conversation to collaborators on Apr 12, 2024
13. pull

    added a commit that references this issue on Jul 1, 2026

    [generator] Mark generated .cs files as generated (#1052)

    ...

    31c83fb