Additional API-30 deprecations #602

Activity

1. jpobst

   added this to the d16-7 milestone on Apr 6, 2020
2. jpobst

   added

   generatorIssues binding a Java library (generator, class-parse, etc.)Issues binding a Java library (generator, class-parse, etc.)

   enhancementProposed change to current functionalityProposed change to current functionality

   on Apr 6, 2020
3. jpobst

   self-assigned this

   on Apr 8, 2020
4. jpobst commented on Apr 14, 2020

   

   jpobst

   on Apr 14, 2020

   ContributorAuthor

   More actions

   I am somewhat concerned about removing the InterfaceConsts classes. The scenario they "fix" is allowing the constants on an inherited interface to be accessed through the implementing class.

   For example:

   interface IFoo { public const int Bar = 3; }
   class Baz : IFoo { }
   

   In Java, you can access this as an "inherited constant" like this:

   new Baz ().Bar
   

   Because we didn't have interface constants in C#, the constant is moved to a class, which we cannot inherit from or we break the inheritance hierarchy:

   class Foo { public const int Bar = 3; }
   class Baz : Java.Lang.Object
   

   Obviously new Baz ().Bar doesn't work here. The workaround was to create the nested InterfaceConsts which theoretically makes it slightly more findable, in that you can do this:

   new Baz ().InterfaceConsts.Bar
   

   With C#8, we now have interface constants, but the way they work in C# means they are only available on the interface and are not accessible via inheritance, thus new Baz ().Bar still doesn't work, even though Baz inherits an interface with a Bar constant. It is only accessible as IFoo.Bar.

   Thus, we have not eliminated the problem InterfaceConsts were trying to fix in the first place: we still do not allow a literal translation from Java code.

   One can argue that InterfaceConsts should be removed just because it's a bad solution in the first place, but we should not remove it simply because we think C#8 fixes the problem it attempts to solve.
5. jpobst commented on Apr 15, 2020

   

   jpobst

   on Apr 15, 2020

   ContributorAuthor

   More actions

   We have decided not to proceed with this and will leave the InterfaceConsts classes as-is.
6. jpobst

   closed this as completedon Apr 15, 2020
7. jpobst

   added

   wontfix

   on Apr 15, 2020
8. github-actions

   locked and limited conversation to collaborators on Apr 13, 2024