Repository navigation
generator should pull parameter names from Javadoc #767
Description
Related? PR #687.
Parameter names remains an ongoing concern. "Best" is if the Java code is built with javac -parameters, which allows class-parse to extract parameter names, and everything is good.
Unfortunately, that still appears to be a rarity in the Java world.
Lacking javac -parameters, how should bindings get decent parameter names? A "reasonable" answer is to integrate @(JavaSourceJar) support, which with PR #687 and dotnet/android#5253 will parse @(JavaSourceJar) with java-source-utils.jar (69e1b80) to extract Javadoc and parameter names.
However, PR #687 is focused on parsing the Javadoc comments and translating them into C# XML Documentation Comments.
We should also look into using generator --with-javadoc-xml=FILE to determine parameter names as well.
Then there's the "priority" question: I think it would be most "sensible" and documentable if the last "source of truth" for parameter names was used in the bindings:
class-parseoutput.java-source-utils.jaroutputMetadata.xmlupdates
This would allow Metadata.xml to always override.
Activity
jonpryor commentedon Jan 5, 2021
On further consideration, I don't think this requires any changes to
generator.Instead, we should update the
_ExportJarToXmltarget so that the output ofjava-source-utils.jaris provided toClassParse.DocumentationPaths. This will causejava-source-utils.jaroutput to be treated identically to Javadoc HTML input files regarding parameter names.Rethink <JavaSourceUtils/> ordering
[Xamarin.Android.Tools.Bytecode] Relax _ApiXml check
[Xamarin.Android.Tools.Bytecode] Relax _ApiXml check (#772)
Bump to xamarin/Java.Interop/master@fdc200cc
Bump to xamarin/Java.Interop/master@fdc200cc
Bump to xamarin/Java.Interop/master@fdc200cc (#5468)