Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

[Java.Interop.Tools.JavaSource] Fix duplication in Remarks generation for property getter/setters #905

Closed

Description

@pjcollins

See: https://github.com/xamarin/android-api-docs/blob/7fc3d7e079e009db5d29dcf6c4d2ca805cc33874/docs/Mono.Android/en/Android.Animation/ValueAnimator.xml#L1416-L1449

There is some duplication in the extra remarks generated for property getters/setters, specifically around the copyright and links out to Java documentation that we need to clean up.

Activity

  1. self-assigned this
    on Nov 2, 2021
  2. changed the title [-]Fix javadoc based Remarks generation for property getter/setters[/-] [+][Java.Interop.Tools.JavaSource] Fix duplication in Remarks generation for property getter/setters[/+] on Nov 2, 2021
  3. jonpryor commented on Nov 9, 2021

    @jonpryor
    Contributor

    Wasn't this fixed in 0e01fb5?

  4. pjcollins commented on Nov 9, 2021

    @pjcollins
    MemberAuthor

    I think it was only fixed for cases with multiple @returns blocks. The problematic docs blob mentioned here was generated after the fix in 0e01fb5 landed, I still need to investigate this case further.

           <remarks>
              <para>Property getter documentation:</para>
              <para>
                <format type="text/html">
                  <a href="https://developer.android.com/reference/android/animation/ValueAnimator#getStartDelay()" title="Reference documentation">Java documentation for <code>android.animation.ValueAnimator.getStartDelay()</code>.</a>
                </format>
              </para>
              <para>
                        Portions of this page are modifications based on work created and shared by the 
                        <format type="text/html"><a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a></format>
                         and used according to terms described in the 
                        <format type="text/html"><a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a></format></para>
              <para>Property setter documentation:</para>
              <para>
                <format type="text/html">
                  <a href="https://developer.android.com/reference/android/animation/ValueAnimator#setStartDelay(long)" title="Reference documentation">Java documentation for <code>android.animation.ValueAnimator.setStartDelay(long)</code>.</a>
                </format>
              </para>
              <format type="text/html">
                <a href="https://developer.android.com/reference/android/animation/ValueAnimator#setStartDelay(long)" title="Reference documentation">Java documentation for <code>android.animation.ValueAnimator.setStartDelay(long)</code>.</a>
              </format>
              <a href="https://developer.android.com/reference/android/animation/ValueAnimator#setStartDelay(long)" title="Reference documentation">Java documentation for <code>android.animation.ValueAnimator.setStartDelay(long)</code>.</a>Java documentation for <code>android.animation.ValueAnimator.setStartDelay(long)</code>android.animation.ValueAnimator.setStartDelay(long).<para>
                        Portions of this page are modifications based on work created and shared by the 
                        <format type="text/html"><a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a></format>
                         and used according to terms described in the 
                        <format type="text/html"><a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a></format></para>
                        Portions of this page are modifications based on work created and shared by the 
                        <format type="text/html"><a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a></format><a href="https://developers.google.com/terms/site-policies" title="Android Open Source Project">Android Open Source Project</a>Android Open Source Project
                         and used according to terms described in the 
                        <format type="text/html"><a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a></format><a href="https://creativecommons.org/licenses/by/2.5/" title="Creative Commons 2.5 Attribution License">Creative Commons 2.5 Attribution License.</a>Creative Commons 2.5 Attribution License.</remarks>
  5. locked and limited conversation to collaborators on Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions