This repository was archived by the owner on Aug 27, 2026. It is now read-only.
Repository navigation
[Xamarin.Android.Tools.Bytecode] Add EnclosingMethod, SourceFile - #469
Merged
Merged
Conversation
jonpryor
force-pushed
the
jonp-enclosingmethod-annotation
branch
from
August 14, 2019 18:13
c892d17 to
5e3be2f
Compare
Context: dotnet#466 While looking at `class-parse --dump` output for various Kotlin-compiled `.class` files, providing support for the `EnclosingMethod` and `SourceFile` annotation blobs looks to be useful. Add support for parsing the `EnclosingMethod` and `SourceFile` annotations. Update the generated XML so that the `SourceFile` annotation is avaialble from the `//class/@source-file-name` or `//interface/@source-file-name` attributes. Update the generated XML so that the `EnclosingMethod` annotation is available from these new attributes on `//class` or `//interface`: * `enclosing-method-jni-type`: The JNI signature of the type declaring the enclosing method. * `enclosing-method-name`: The name of the enclosing method. * `enclosing-method-signature`: The JNI signature of the enclosing method. For example, if `TestType.action()` had an anonymous inner class: class TestType { public void action (Object value) { Runnable r = new Runnable () { public void run() { System.out.println ("foo"); } }; } } This could result in the creation of a new `TestType$1` class for the anonymous inner class, with the resulting `enclosing-*` attributes: enclosing-method-jni-type="Lcom/xamarin/JavaType;" enclosing-method-name="action" enclosing-method-signature="(Ljava/lang/Object;)V"
jonpryor
force-pushed
the
jonp-enclosingmethod-annotation
branch
from
August 15, 2019 15:02
5e3be2f to
0dbc003
Compare
Contributor
Author
|
It helps if I commit & push my entire local patch... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #466
While looking at
class-parse --dumpoutput for variousKotlin-compiled
.classfiles, providing support for theEnclosingMethodandSourceFileannotation blobs looks to beuseful.
Add support for parsing the
EnclosingMethodandSourceFileannotations.
Update the generated XML so that the
SourceFileannotation isavaialble from the
//class/@source-file-nameor//interface/@source-file-nameattributes.Update the generated XML so that the
EnclosingMethodannotation isavailable from these new attributes on
//classor//interface:enclosing-method-jni-type: The JNI signature of the typedeclaring the enclosing method.
enclosing-method-name: The name of the enclosing method.enclosing-method-signature: The JNI signature of the enclosingmethod.
For example, if
TestType.action()had an anonymous inner class:This could result in the creation of a new
TestType$1class for theanonymous inner class, with the resulting
enclosing-*attributes: