You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 25, 2026. It is now read-only.
[feature/dataflow] Add a pre-pass to scan type name strings in the app #1079
Due to structure of the step architecture in linker, steps that might optionally pull in new assembly dependencies into the closure currently need to run a global pre-pass over the entire app before we reach MarkStep. This architectural deficiency will have to be fixed at some point, but before we do that, dataflow will also need to run such inefficient global prepass to locate all strings stored into locations marked with DynamicallyAccessedMemebers so that we can potentially add new assemblies into the closure.
We should do whatever is the fastest thing. We could potentially do something as dumb as going over all user strings in the assembly, looking for ones that look like a fully qualified type name (have a comma in it and maybe some other heuristics to trim the list of looked at strings down) and try to open the associated assembly, so that we don't need to actually parse IL.
Plus we need to scan custom attributes if their constructor/setter/field is marked DynamicallyAccessed.
Activity
Enable recursive processing of dynamic assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
Enable processing of dynamically referenced assemblies
sbomer commentedon Mar 12, 2021
No longer necessary because with #1666 later steps can pull in new assemblies and they will still get processed correctly.