Reflection patterns can not resolve assemblies outside of the reference closure

When a supported reflection pattern references an assembly that is part of the linker input set, but not in the reference closure of any roots (and thus not loaded into the LinkContext assemblies by LoadReferencesStep or any other step that comes before MarkStep), the pattern will fail to resolve. Since simple reflection patterns are often used for activation without a build-time dependency, this seems like something worth supporting. See dotnet/sdk#4017 for the original issue with a repro.

#843 is a similar issue where PreserveDependency doesn't cause xml roots from the referenced assembly to be processed.

If we fix this, we should be able to undo dotnet/runtime#32023.

Enable recursive processing of dynamic assemblies

Enable processing of dynamically referenced assemblies

@sbomer

I believe this should be fixed. @sbomer could you please undo the runtime change so we can fully verify this and close ?

Fixed by #1666, runtime workarounds removed in dotnet/runtime#49523.

Navigation Menu

Repository navigation

Reflection patterns can not resolve assemblies outside of the reference closure #943

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Reflection patterns can not resolve assemblies outside of the reference closure #943

Description

Activity

marek-safar commented on Feb 26, 2021

sbomer commented on Mar 12, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions