Repository navigation
[QUIC] Improve MSQuic OS Version detection #32575
Description
Environment.OSVersion is an unreliable API that reports old versions for compat purposes. It only reports the correct Win10 version if an app manifest is added. VS and the test runner have this manifest but sample apps and customer apps won't.
https://stackoverflow.com/questions/33328739/system-environment-osversion-returns-wrong-version
We're going to need a different way to check for this support. Worst case we look at the registry.
Activity
am11 commentedon Feb 20, 2020
fwiw, dotnet-cli uses this property for
dotnet --info, which I think does not rely on the app manifest:runtime/src/installer/managed/Microsoft.DotNet.PlatformAbstractions/RuntimeEnvironment.cs
Line 16 in cf43585
jkotas commentedon Feb 20, 2020
Microsoft.DotNet.PlatformAbstractions package is obsolete.
P/Invoking
Ntdll.RtlGetVersionExis your best bet.jkotas commentedon Feb 20, 2020
This is considered to be a feature. It is not necessary something you want to "fix".
am11 commentedon Feb 20, 2020
will its sources be removed and dotnet-cli switch to p/invoke?
Edit: nvm, found the issue tracking it - #3470
Tratcher commentedon Feb 20, 2020
This version check is to see if the OS has the right TLS 1.3 support. Http3 will have other opt-in guards to maintain compat. Once a developer opts in, false negatives from this version check are an unnecessary hurdle and support burden.
[-]Improve MSQuic OS Version detection[/-][+][QUIC] Improve MSQuic OS Version detection[/+]Tratcher commentedon May 12, 2020
#33643 fixed Environment.OSVersion so we can depend on that again.
eerhardt commentedon May 12, 2020
@Tratcher - do you want me to update #36302 to add back the Environment.OSVersion check?
Tratcher commentedon May 12, 2020
@jkotalik have you confirmed which version we need?
jkotalik commentedon May 12, 2020
No, let's just merge what we have in that #36302 for now. I'll need to figure out if the Windows slow preview train has schannel support, which will take a while.
scalablecory commentedon Sep 23, 2020
I'm thinking it's better to implement this in MsQuic -- microsoft/msquic#92
ManickaP commentedon Apr 15, 2021
This can be covered by analyzers with
SupportedOSPlatform, first crude draft is already in #49261, we just need a complete list of supported OS/versions/distros.edit:
This will not help with checking the minimal Windows version. However, that should be a one-liner in S.N.Quic initialization: https://docs.microsoft.com/en-us/dotnet/api/system.operatingsystem.iswindowsversionatleast?view=net-5.0.