Repository navigation
Fix ThreadNameDoesNotAffectProcessName for Mono #35908
Description
Activity
- added a commit that references this issue
on May 6, 2020 We have
MonoThreadInfo *mono_thread_info_lookup (MonoNativeThreadId tid)so one way to do this is to add aguint64 os_idfield toMonoThreadInfo.The downside of
mono_thread_info_lookupis it's a linear scan, which isn't great.Hm. Actually a faster way might just be to add a global "main thread"
MonoNativeThreadIdand set it inregister_threadwhen we seegetpid () == mono_native_thread_os_id_get ()- added a commit that references this issue
on May 12, 2020 - added a commit that references this issue
on May 12, 2020 - added a commit that references this issue
on May 29, 2020 - ghost locked as resolved and limited conversation to collaborators
on Dec 9, 2020
See #34064
We need a check in
mono_native_thread_set_nameon Linux that thetiddoes not represent the main thread of the program (in the sense that on Linuxgettid () == getpid ()for the main thread).The problem is that
mono_native_thread_set_namegets aMonoNativeThreadId(which ispthread_ton Linux) and we need to compare that to the OS thread id of the main thread (which is apid_t-gettid ()of the main thread is the same asgetpid()).We have
mono_native_thread_os_id_get ()but it only returns thepid_tof the current thread - not of an arbitraryMonoNativeThreadId.So we need some mechanism to go from a
MonoNativeThreadId(or maybe aMonoThreadInfo) to a native OS thread id.