You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
WebAssembly should support handling runtimeconfig.json #38433
Could you clarify why? We'd need to copy the files to the temp file system and add all the baggage for handling the json logic which is not necessary for self-contained setup.
I think a better approach is to add the configProperties section which is probably the only relevant part for self-contained configs to csproj PropertyGroup and handle it during build.
Yeah I was imprecise when creating the title, I don't think we need to necessarily read the file as part of the WASM process but we need to handle it somehow rather than just ignoring it.
changed the title [-]WebAssembly should support reading runtimeconfig.json[/-][+]WebAssembly should support handling runtimeconfig.json[/+]on Jun 30, 2020
I think a better approach is to add the configProperties section which is probably the only relevant part for self-contained configs to csproj PropertyGroup and handle it during build.
Do you mean - read the configProperties section of the runtimeConfig.json, and add it to the build, so that we don't have to support reading runtimeConfig.json itself in the wasm app?
Yea, this is exactly what the runtimeConfig.json task is meant to do. The WasmApp target needs to be updated to use it, and then driver.c needs to be updated to call the runtime API that consumes the binary blob of the parsed json file.
Is this going to be completed for .NET 6? Using AppContext switches is becoming more and more important in order to support feature switches. For example, the plan in #55102 is relying on the fact that an AppContext switch will be set in applications that will be trimmed during F5/dotnet run.
Is this going to be completed for .NET 6? Using AppContext switches is becoming more and more important in order to support feature switches. For example, the plan in #55102 is relying on the fact that an AppContext switch will be set in applications that will be trimmed during F5/dotnet run.
Activity
marek-safar commentedon Jun 30, 2020
Could you clarify why? We'd need to copy the files to the temp file system and add all the baggage for handling the json logic which is not necessary for self-contained setup.
I think a better approach is to add the configProperties section which is probably the only relevant part for self-contained configs to csproj PropertyGroup and handle it during build.
akoeplinger commentedon Jun 30, 2020
Yeah I was imprecise when creating the title, I don't think we need to necessarily read the file as part of the WASM process but we need to handle it somehow rather than just ignoring it.
[-]WebAssembly should support reading runtimeconfig.json[/-][+]WebAssembly should support handling runtimeconfig.json[/+]radical commentedon May 24, 2021
Do you mean - read the
configPropertiessection of theruntimeConfig.json, and add it to the build, so that we don't have to support readingruntimeConfig.jsonitself in the wasm app?marek-safar commentedon May 25, 2021
We should just leverage the runtimeConfig.json task we have for mobile AOT for WASM AOT
lambdageek commentedon Jun 22, 2021
Yea, this is exactly what the runtimeConfig.json task is meant to do. The WasmApp target needs to be updated to use it, and then driver.c needs to be updated to call the runtime API that consumes the binary blob of the parsed json file.
SamMonoRT commentedon Jul 9, 2021
cc @lewing @radical - Fan will give this a shot.
eerhardt commentedon Jul 28, 2021
Is this going to be completed for .NET 6? Using AppContext switches is becoming more and more important in order to support feature switches. For example, the plan in #55102 is relying on the fact that an AppContext switch will be set in applications that will be trimmed during
F5/dotnet run.SamMonoRT commentedon Jul 28, 2021
Yes, a PR should be up soon