Skip to content

verifyFinalAllocation should track regsToFree/delayRegsToFree #48837

Open
Open
verifyFinalAllocation should track regsToFree/delayRegsToFree#48837
Labels
Priority:3Work that is nice to havearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Description

@kunalspathak
kunalspathak
opened on Feb 26, 2021

Currently, the code inside verifyFinalAllocation() doesn't track regsToFree and delayRegsToFree and they are always set to RBM_NONE. Investigate, the right way to check for these fields.

For now, as part of #48829, they are removed.

category:cq
theme:register-allocator

Activity

  1. ghost added
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    on Feb 26, 2021
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Feb 26, 2021
  3. kunalspathak
    self-assigned this
    on Feb 26, 2021
  4. JulieLeeMSFT
    removed
    untriagedNew issue has not been triaged by the area owner
    on Mar 2, 2021
  5. JulieLeeMSFT
    added this to the 6.0.0 milestone on Mar 2, 2021
  6. kunalspathak
    added 2 commits that reference this issue on Mar 2, 2021

    Delete regsToFree and delayRegsToFree from verifyFinalAllocation

    6bac5b5

    Fix majority of failures in libraries-jitstressregs after EHWriteThru…

    b51270d
  7. kunalspathak
    added
    Priority:3Work that is nice to have
    on Jun 4, 2021

  8. kunalspathak commented on Jun 4, 2021

    @kunalspathak
    kunalspathak
    on Jun 4, 2021
    ContributorAuthor

    I will try to get to this in .NET6.0, but marking it as Pri3.

  9. kunalspathak
    modified the milestones: 6.0.0, Future on Aug 13, 2021
  10. JulieLeeMSFT
    unassigned
    kunalspathak
    on Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority:3Work that is nice to havearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions