Skip to content

[mono] Allow CustomAttribute table modifications if Parent stays unchanged #55097

Closed

Description

@lambdageek

Allow nullability analysis of modified method bodies.

Roslyn emits nullability attributes by emitting an update to a CustomAttribute table row when a method body is updated.
In most(all?) cases the Constructor stays the same too. The value might or might not change, but we don't care.

This is distinct from supporting full custom attribute changes. In this case Roslyn doesn't consider a CA row update as a rude edit even with just Baseline capabilities.

(Previously Roslyn used to emit new CA rows when a method body was updated. Mono ignored it because we tacitly allow through many row additions to most tables. Modifications we scrutinize.)

After this is fixed the ApplyUpdateTest and the hot reload functional tests can be updated to re-enable Nullability analysis for the modifiable assembly projects.

Contributes to #44806

Activity

  1. added this to the 6.0.0 milestone on Jul 2, 2021
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jul 2, 2021
  3. removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 2, 2021
  4. self-assigned this
    on Jul 2, 2021
  5. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 10, 2021
  6. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 12, 2021
  7. ghost locked as resolved and limited conversation to collaborators on Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-EnC-monoHot Reload for WebAssembly, iOS/Android, etc

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions