Skip to content

DecompressionHandler could move the headers more efficiently #63632

Closed
#122676
Closed
DecompressionHandler could move the headers more efficiently#63632
#122676
Labels
area-System.Net.HttpenhancementProduct code improvement that does NOT require public API changes/additionsin-prThere is an active PR which will close this issue when it is mergedtenet-performancePerformance related issue
Milestone
11.0.0

Description

@MihaZupan
MihaZupan
opened on Jan 11, 2022

DecompressionHandler will replace the Content on the HttpResponseMesasge with a new one wrapping the decompression stream. It also copies over all the headers from the response.

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/DecompressionHandler.cs

Line 121 in 59b55a2

Headers.AddHeaders(originalContent.Headers);

Since DecompressionHandler is internal and the user can never observe the original response content, we could assign the header collection to the new content instead of copying all the values.

We do something similar for trailing headers already:

runtime/src/libraries/System.Net.Http/src/System/Net/Http/HttpResponseMessage.cs

Line 121 in 59b55a2

internal void StoreReceivedTrailingHeaders(HttpResponseHeaders headers)

Activity

  1. MihaZupan
    added
    area-System.Net.Http
    tenet-performancePerformance related issue
    on Jan 11, 2022
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jan 11, 2022
  4. karelz
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    and removed
    untriagedNew issue has not been triaged by the area owner
    on Jan 13, 2022
  5. karelz
    added this to the Future milestone on Jan 13, 2022

  6. karelz commented on Jan 13, 2022

    @karelz
    karelz
    on Jan 13, 2022
    Member

    Triage: Possible to do, unlikely to have visible perf impact.

  7. dotnet-policy-service
    added
    in-prThere is an active PR which will close this issue when it is merged
    on Dec 20, 2025
  8. MihaZupan
    modified the milestones: Future, 11.0.0 on Dec 20, 2025
  9. MihaZupan
    closed this as completedin #122676on Jan 7, 2026
  10. github-actions
    locked and limited conversation to collaborators on Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Net.HttpenhancementProduct code improvement that does NOT require public API changes/additionsin-prThere is an active PR which will close this issue when it is mergedtenet-performancePerformance related issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions