TryAddWithoutValidation for multiple values could be more efficient

The method takes an IEnumerable<string>. Things we could improve:

For example

TryAddWithoutValidation("foo", "1");
TryAddWithoutValidation("foo", new[] { "2", "3" });

Will currently allocate the enumerator, a List<string> of size 2, and a List<string> of size 4.

We can reduce that down to allocating a single List<string> of size 3.

Triage: Worth investment, but the method is not commonly used, so not priority.

@karelz

I am confident that this will grant a performance advantage. As @karelz mentioned, this does not seem to be a method on the hot path.

@MihaZupan
Do you feel like submitting a pull request and also creating a benchmark in dotnet/performance?

It's not a priority for us for now, but I'll happily review a PR if you are interested :)

Navigation Menu