Prevent placing ref fields on non-pointer boundaries

Similar to #12842 except for the following struct:

[StructLayout(LayoutKind.Explicit)]
ref struct RefStruct
{
    [FieldOffset(0)]
    public short X;
    [FieldOffset(2)]
    ref int Y;
}

We should not allow this to load.

I have the CoreCLR fix for this. The Mono changes are bit more complex and taking some time.

I have the CoreCLR fix for this. The Mono changes are bit more complex and taking some time.

FWIW, Mono doesn't even detect #12842.

There's not even a bug for it because I don't think Mono ever ran a Pri-1 CoreCLR test pass (the regression test is Pri-1). If you make your regression test Pri-1, you can save yourself some work. It's not a Pri-0 scenario.

@MichalStrehovsky

@MichalStrehovsky I've spent most of the day getting Mono in the right state. I am hitting issues now that are really confusing. I am close to doing what you suggest. Likely will make the call tomorrow.

Navigation Menu

Repository navigation

Prevent placing ref fields on non-pointer boundaries #64520

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Prevent placing ref fields on non-pointer boundaries #64520

Description

Activity

AaronRobinsonMSFT commented on Jan 31, 2022

MichalStrehovsky commented on Feb 1, 2022

AaronRobinsonMSFT commented on Feb 1, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions