Skip to content

[Mono] Revisit the signedness of the index argument of metadata methods #70495

Open

Description

@fanyang-mono

Metadata methods to consider:

  • mono_metadata_table_bounds_check in src\mono\mono\metadata\metadata-internals.h
  • Return of table_info_get_rows in src\mono\mono\metadata\metadata-internals.h
  • Return of mono_metadata_table_num_rows in src\mono\mono\metadata\metadata-internals.h
  • mono_metadata_decode_table_row in src\mono\mono\metadata\metadata.c
  • mono_metadata_decode_row_col in src\mono\mono\metadata\metadata.c
  • mono_metadata_decode_row in src\mono\mono\metadata\metadata.c
  • mono_metadata_decode_row_slow in src\mono\mono\metadata\metadata.c
  • The local var which stores the return of mono_metadata_token_index
  • end_idx of mono_metadata_methods_from_event should be guint32 * in src\mono\mono\metadata\metadata.c

The above ones are the ones that I observed, which may not be complete.

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jun 9, 2022
  2. removed
    untriagedNew issue has not been triaged by the area owner
    on Jun 14, 2022
  3. modified the milestones: Future, 8.0.0 on Jun 14, 2022
  4. modified the milestones: 8.0.0, Future on Jul 26, 2022
  5. fanyang-mono commented on Jul 24, 2023

    @fanyang-mono
    MemberAuthor

    Moving to 9.0.0

  6. modified the milestones: 8.0.0, 9.0.0 on Jul 24, 2023
  7. modified the milestones: 9.0.0, Future on Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions