Skip to content

runtime-community leg failing for ThreadPoolMinMaxThreadsEventTest #71173

Closed

Description

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jun 22, 2022
  2. tannergooding commented on Jun 22, 2022

    @tannergooding
    MemberAuthor

    Notably the community leg is for linux release s390x mono. It represents a big endian platform.

  3. uweigand commented on Jun 23, 2022

    @uweigand
    Contributor

    Thanks for reporting this!

    Looking at the failing test, we have this failed assertion:

              Child exception:
                Xunit.Sdk.EqualException: Assert.Equal() Failure
              Expected: 3
              Actual:   768
              /home/uweigand/runtime/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs(1147,0): at System.Threading.ThreadPools.Tests.ThreadPoolTests.<>c.<ThreadPoolMinMaxThreadsEventTest>b__42_0()
    

    Note that 768 is 0x300 and this value is of type uint16_t, so it looks like a missed endian conversion.

    I think this is related to the general endian problems with eventpipe that @stefan-sf has been working on for a while, see in particular #68648. @stefan-sf can you confirm that that PR would fix this new issue as well?

  4. stefan-sf-ibm commented on Jun 28, 2022

    @stefan-sf-ibm
    Contributor

    Did a rebase today and can confirm that ThreadPoolMinMaxThreadsEventTest passes if #68648 is applied.

  5. uweigand commented on Jun 28, 2022

    @uweigand
    Contributor

    Thanks, @stefan-sf-ibm !

  6. mangod9 commented on Jul 7, 2022

    @mangod9
    Member

    so this issue can be closed I assume?

  7. uweigand commented on Jul 7, 2022

    @uweigand
    Contributor

    Yes, our CI is now green again. This issue can be closed.

  8. mangod9 commented on Jul 7, 2022

    @mangod9
    Member

    Thx!

  9. ghost removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 7, 2022
  10. ghost locked as resolved and limited conversation to collaborators on Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions