Skip to content

[QUIC] QuicConnection API follow up #72027

Description

@ManickaP
  • it should AFAIK. It would be nice to have some assert about it. It differs among platforms but MsQUIC now uses native layout e.g. same as SocketAddress.

Originally posted by @wfurt in #71783 (comment)

  • It would be nice to throw or at least log. I know this is what we we in SslStream for historical reasons but the failures when we silently ignore given certificate are annoying IMHO.
    (this could be separate work)

Originally posted by @wfurt in #71783 (comment)

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jul 12, 2022
  2. removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 12, 2022
  3. added this to the 7.0.0 milestone on Jul 12, 2022
  4. self-assigned this
    on Jul 14, 2022
  5. ManickaP commented on Jul 14, 2022

    @ManickaP
    MemberAuthor

    It would be nice to have some assert about it.

    @wfurt how would we assert that the layout is the same? We have an assert about size, but I'm not sure what else we could do, any ideas?

  6. wfurt commented on Jul 14, 2022

    @wfurt
    Member

    perhaps separate test for the helper? Serialize given buffer as SocketAddress and compare equality?
    AFAIK the only one special case was macOS were the layout was different. Conceptually, test would probably fail on platforms where we do it wrong. Perhaps just remove the comment with the doubts....?

  7. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 18, 2022
  8. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 18, 2022
  9. ghost locked as resolved and limited conversation to collaborators on Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions