Skip to content

Reconsider naming of ObsoletedInOSPlatformAttribute #72970

Closed

Description

@terrajobst

From @jeffhandley delivered by @buyaa-n:

Immo we wonder why the ObsoletedInOSPlatformAttribute has In where others just SupportedOSPlatformAttribute and UnsupportedOSPlatformAttribute, our messaging structure is like

This call site is reachable on {platforms list}. 'The.API' is supported on: {platforms list}

Then the Obsoleted attribute as In but the message will have on:

This call site is reachable on {platforms list}. 'The.API' is obsoleted on: {platforms list}

We might want to change the attribute to similar ObsoletedOSPlatformAttribute or there is specific reason of having In? 

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jul 27, 2022
  2. added
    blockingMarks issues that we want to fast track in order to unblock other important work
    and removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 27, 2022
  3. added this to the 7.0.0 milestone on Jul 27, 2022
  4. terrajobst commented on Aug 2, 2022

    @terrajobst
    ContributorAuthor
    • We decided to rename it to match other attributes
     namespace System.Runtime.Versioning;
    
    -public sealed class ObsoletedInOSPlatformAttribute : OSPlatformAttribute
    +public sealed class ObsoletedOSPlatformAttribute : OSPlatformAttribute
  5. added
    api-approvedAPI was approved in API review, it can be implemented
    and removed
    api-ready-for-reviewAPI is ready for review, it is NOT ready for implementation
    on Aug 2, 2022
  6. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Aug 9, 2022
  7. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Aug 9, 2022
  8. ghost locked as resolved and limited conversation to collaborators on Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api-approvedAPI was approved in API review, it can be implementedarea-System.RuntimeblockingMarks issues that we want to fast track in order to unblock other important work

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions