You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Newly added intellisense msbuild conditions cause overbuild #82191
Just realized that the '$(TargetFramework)' == '$(NetCoreAppCurrent)' condition results in a behavior difference and will force us to overbuild. When building the repo, by default only the nearest NetCoreAppCurrent tfm will be built. In the case of building on Windows, this means net8.0-windows or net8.0 if projects don't have a corresponding windows platform TFM.
We should remove that artificial limitation and restore the previous behavior. I could see the following cases to apply:
A project doesn't multi-target => use NetCoreAppCurrent condition (status quo).
A project multi-targets and all inner builds are built (no tfm filtering) => run this target in the NetCoreAppCurrent inner build (status quo).
A project multi-targets but an inner build runs stand-alone (tfm filtering) => Don't condition on a TFM.
I don't know if it's possible to determine the third case in an msbuild environment, but that's the default build behavior in dotnet/runtime and will be utilized in the VMR with RID builds. Therefore we should try to make that work.
Activity
ViktorHofer commentedon Jun 28, 2023
Fixed by #87603