[wasm][debugger] KeepNativeSymbols=true breaks SteppingTests.SkipWasmFunctionsAccordinglyJustMyCode

If you build a runtime with -p:KeepNativeSymbols=true and then run the debugger testsuite, SteppingTests.SkipWasmFunctionsAccordinglyJustMyCode will fail.

Note that we don't ship KeepNativeSymbols, so this is purely something that is a papercut when working on dotnet/runtime itself.

Repro steps:

./build.sh --os browser -c Debug -bl -nr:false -p:KeepNativeSymbols=true

then

make -C src/mono/wasm run-debugger-tests CONFIG=Debug TEST_FILTER='~SteppingTests.SkipWasmFunctionsAccordinglyJustMyCode'

This is probably related to given how we look for stack frames in MonoProxy.SendCallStack:

runtime/src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs

Lines 1119 to 1133 in 7692f98

    
           foreach (JObject frame in orig_callframes) 
        
           { 
        
               string function_name = frame["functionName"]?.Value<string>(); 
        
               string url = frame["url"]?.Value<string>(); 
        
               var isWasmExpressionStack = frame["scopeChain"]?[0]?["type"]?.Value<string>()?.Equals("wasm-expression-stack") == true; 
        
               if (!(function_name.StartsWith("wasm-function", StringComparison.Ordinal) || 
        
                       url.StartsWith("wasm://", StringComparison.Ordinal) || 
        
                       url.EndsWith(".wasm", StringComparison.Ordinal) || 
        
                       JustMyCode && isWasmExpressionStack || 
        
                       function_name.StartsWith("_mono_wasm_fire_debugger_agent_message", StringComparison.Ordinal) || 
        
                       function_name.StartsWith("mono_wasm_fire_debugger_agent_message", StringComparison.Ordinal))) 
        
               { 
        
                   callFrames.Add(frame); 
        
               } 
        
           }

With KeepNativeSymbols it's possible that some of those wasm-function symbols will have real names instead

~~Why keeping the symbols fail and not keeping them works ?~~

Oh wasm/native symbols will not have wasm-function prefix on it.

@thaystg

cc @thaystg

This test is expected to not work in debug runtime builds, only in release.

Navigation Menu

Repository navigation

[wasm][debugger] KeepNativeSymbols=true breaks SteppingTests.SkipWasmFunctionsAccordinglyJustMyCode #86387

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	foreach (JObject frame in orig_callframes)
	{
	string function_name = frame["functionName"]?.Value<string>();
	string url = frame["url"]?.Value<string>();
	var isWasmExpressionStack = frame["scopeChain"]?[0]?["type"]?.Value<string>()?.Equals("wasm-expression-stack") == true;
	if (!(function_name.StartsWith("wasm-function", StringComparison.Ordinal) \|\|
	url.StartsWith("wasm://", StringComparison.Ordinal) \|\|
	url.EndsWith(".wasm", StringComparison.Ordinal) \|\|
	JustMyCode && isWasmExpressionStack \|\|
	function_name.StartsWith("_mono_wasm_fire_debugger_agent_message", StringComparison.Ordinal) \|\|
	function_name.StartsWith("mono_wasm_fire_debugger_agent_message", StringComparison.Ordinal)))
	{
	callFrames.Add(frame);
	}
	}

[wasm][debugger] KeepNativeSymbols=true breaks SteppingTests.SkipWasmFunctionsAccordinglyJustMyCode #86387

Description

Activity

lambdageek commented on May 17, 2023

pavelsavara commented on Aug 10, 2023

pavelsavara commented on Aug 11, 2023

thaystg commented on Aug 14, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions