You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@MichalStrehovsky the tryrun.cmake contains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS. This is a cmake concept - the tryrun.cmake is meant to be separate, as it is loaded by cmake as an initialization of its cache.
It is not clear to me how we could reasonably unify these.
@MichalStrehovsky the tryrun.cmake contains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS.
Yes, it's the same thing that the quoted part of configure.cmake is also doing. It's not clear why we spread these around the codebase
Activity
janvorli commentedon May 29, 2023
@MichalStrehovsky the
tryrun.cmakecontains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS. This is a cmake concept - thetryrun.cmakeis meant to be separate, as it is loaded by cmake as an initialization of its cache.It is not clear to me how we could reasonably unify these.
MichalStrehovsky commentedon May 29, 2023
Yes, it's the same thing that the quoted part of configure.cmake is also doing. It's not clear why we spread these around the codebase
janvorli commentedon May 29, 2023
Oh, I am surprised to see it in the configure.cmake in libraries. The ones in coreclr don't have that, they use the tryrun.cmake.
ViktorHofer commentedon Jul 20, 2023
@akoeplinger as you are assigned, should this stay in 8.0.0 or be moved?
akoeplinger commentedon Jul 20, 2023
@ViktorHofer it can stay in 8.0 for now
ilonatommy commentedon Jul 4, 2024
@akoeplinger, this looks like a fast cleanup issue, will you have capacity for it?
akoeplinger commentedon Jul 4, 2024
Hopefully 😄