Skip to content

Unify tryrun scripts #86829

Open
Open

Description

@MichalStrehovsky

#86781 (comment)

We have tryrun.cmake that is mostly used for -cross builds.

Then we have similar things in runtime/src/native/libs/configure.cmake and https://github.com/dotnet/runtime/blob/main/eng/native/tryrun_ios_tvos.cmake.

We should reconcile this.

Related: #56622

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 27, 2023
  2. janvorli commented on May 29, 2023

    @janvorli
    Member

    @MichalStrehovsky the tryrun.cmake contains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS. This is a cmake concept - the tryrun.cmake is meant to be separate, as it is loaded by cmake as an initialization of its cache.
    It is not clear to me how we could reasonably unify these.

  3. MichalStrehovsky commented on May 29, 2023

    @MichalStrehovsky
    MemberAuthor

    @MichalStrehovsky the tryrun.cmake contains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS.

    Yes, it's the same thing that the quoted part of configure.cmake is also doing. It's not clear why we spread these around the codebase

  4. janvorli commented on May 29, 2023

    @janvorli
    Member

    Oh, I am surprised to see it in the configure.cmake in libraries. The ones in coreclr don't have that, they use the tryrun.cmake.

  5. added this to the 8.0.0 milestone on Jun 7, 2023
  6. removed
    untriagedNew issue has not been triaged by the area owner
    on Jun 7, 2023
  7. ViktorHofer commented on Jul 20, 2023

    @ViktorHofer
    Member

    @akoeplinger as you are assigned, should this stay in 8.0.0 or be moved?

  8. akoeplinger commented on Jul 20, 2023

    @akoeplinger
    Member

    @ViktorHofer it can stay in 8.0 for now

  9. modified the milestones: 8.0.0, 9.0.0, 8.0.1 on Oct 25, 2023
  10. ilonatommy commented on Jul 4, 2024

    @ilonatommy
    Member

    @akoeplinger, this looks like a fast cleanup issue, will you have capacity for it?

  11. akoeplinger commented on Jul 4, 2024

    @akoeplinger
    Member

    Hopefully 😄

  12. modified the milestones: 9.0.0, 10.0.0 on Jul 22, 2024
  13. modified the milestones: 10.0.0, 11.0.0 on Jul 16, 2025
  14. modified the milestones: 11.0.0, 12.0.0 on Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions