Skip to content

Enable relevant thread pool events in Windows #87020

Closed

Description

@LakshanF

It seems like some IO threadpool events (IOPack, IOEnqueue, and IODequeue) can be enabled for windows in NativeRuntimeEventSource.PortableThreadPool. Given that NativeAOT now has EventPipe, we should do this work to help customers with their diagnostics scenarios.

cc @eduardo-vp, @kouvel

Activity

  1. added this to the 8.0.0 milestone on Jun 1, 2023
  2. kouvel commented on Jul 20, 2023

    @kouvel
    Contributor

    The portable thread pool implementation should already be raising the events on Windows and Unixes (though last I checked a while back, they weren't working yet). #88894 is adding the raising of some events for the Windows thread pool implementation.

  3. kouvel commented on Jul 20, 2023

    @kouvel
    Contributor

    Aside from IOPack, which seemingly is not raised currently on NativeAOT Windows

  4. ghost locked as resolved and limited conversation to collaborators on Sep 8, 2023
  5. LakshanF commented on Jul 12, 2024

    @LakshanF
    ContributorAuthor

    ThreadPoolIOWork event is not yet working in Windows (either with the UseWindowsThreadPool property set to false or not).

    NativeRuntimeEventSourceTest can be used to validate this.

  6. removed this from the 8.0.0 milestone on Jul 12, 2024
  7. MichalStrehovsky commented on Jul 12, 2024

    @MichalStrehovsky
    Member

    I assume we don't want this in the 8.0 milestone that nobody is looking at anymore, so marked this untriaged.

  8. eduardo-vp commented on Aug 27, 2024

    @eduardo-vp
    Member

    The cause of this issue is the same as this one #105556 and was fixed by #106641.

    I also verified the test fails before the fix and passes after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

  • Status
    No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions