Skip to content

Adding a new listener to EventPipeEventDispatcher temporarily stops emitting events for existing sessions #90052

Description

@davmason

In EventPipeEventDispatcher we currently have a shared session for all EventListeners, whenever a new listener is added we will stop the existing session and then start a new session with the combined keywords/level. This has the side effect that for existing listeners we will drop events that happen between stopping the old session and starting the new one, as well as any unread events from the old session when we stop delivering events.

We can address this by changing the logic to update the keywords/level rather than starting and stopping. I have a first attempt at this at https://github.com/davmason/runtime/tree/eventpipe_update

Activity

  1. added this to the 9.0.0 milestone on Aug 4, 2023
  2. added
    enhancementProduct code improvement that does NOT require public API changes/additions
    on Nov 18, 2023
  3. modified the milestones: 9.0.0, Future on Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Tracing-coreclrenhancementProduct code improvement that does NOT require public API changes/additions

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions