Skip to content

Revert "Reenable ClientDisableTlsResume_Succeeds test" - #113730

Merged
rzikm merged 1 commit into
mainfrom
revert-113604-103449-SslStreamTlsResumeTestsClientDisableTlsResume_Succeeds-failed-in-CI
Mar 21, 2025
Merged

rzikm merged 1 commit into
mainfrom
revert-113604-103449-SslStreamTlsResumeTestsClientDisableTlsResume_Succeeds-failed-in-CI

Conversation

@rzikm

@rzikm rzikm commented Mar 20, 2025

Copy link
Copy Markdown
Member

Reverts #113604

The test still seems to fail, see #103449 (comment)

Copilot AI review requested due to automatic review settings March 20, 2025 14:29
@rzikm
rzikm requested a review from a team March 20, 2025 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that reenabled the ClientDisableTlsResume_Succeeds test because the test continues to fail on Windows.

  • Reintroduces an ActiveIssue attribute to disable the failing test
  • Targets the SslStreamAllowTlsResumeTests.cs file

@rzikm

rzikm commented Mar 21, 2025

Copy link
Copy Markdown
Member Author

/ba-g test failures are unrelated

@rzikm
rzikm merged commit 1f06729 into main Mar 21, 2025
@jkotas
jkotas deleted the revert-113604-103449-SslStreamTlsResumeTestsClientDisableTlsResume_Succeeds-failed-in-CI branch March 23, 2025 02:42
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants