Repository navigation
Track HTTP/3 response header budget per-header like HTTP/2 - #128634
Merged
MihaZupan merged 3 commits intoJun 4, 2026
Merged
Conversation
Co-authored-by: MihaZupan <[email protected]>
Copilot
AI
changed the title
[WIP] Implement TODO for response header length limits
Track HTTP/3 response header budget per-header like HTTP/2
May 27, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
reviewed
May 27, 2026
Co-authored-by: Miha Zupan <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how HTTP/3 enforces MaxResponseHeadersLength (advertised via SETTINGS_MAX_HEADER_LIST_SIZE) by tracking the remaining header budget per decoded header entry (name length + value length) rather than charging against the compressed HEADERS frame payload size. This aligns HTTP/3’s behavior with the existing HTTP/2 implementation in Http2Stream.
Changes:
- Removed the HEADERS frame-payload-length-based budget check/subtraction in
ReadHeadersAsync. - Enforced the response header budget during QPACK decoding by decrementing
_headerBudgetRemainingper header inOnHeaderand aborting the QUIC read direction withH3_EXCESSIVE_LOADwhen exceeded.
MihaZupan
approved these changes
May 27, 2026
MihaZupan
marked this pull request as ready for review
May 27, 2026 11:52
rzikm
approved these changes
May 27, 2026
ManickaP
approved these changes
May 27, 2026
MihaZupan
enabled auto-merge (squash)
May 27, 2026 12:15
This was referenced May 27, 2026
Member
|
/ba-g iOS dead letter |
MihaZupan
deleted the
copilot/implement-todo-response-header-length-limits-again
branch
June 4, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches our accounting logic with HTTP/2.
Existing
SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3tests exercise this path.