Repository navigation
[release/10.0] JIT: bail from optOptimizeBoolsCondBlock on GTF_UNSIGNED inputs - #128960
Merged
Merged
Conversation
optOptimizeBoolsCondBlock folds pairs of BBJ_COND blocks of the form "(x == 0) || (x relop 0)" into a single directional comparison. Mirror the existing check at the (LT,LT)/(LT,GE) folds and bail out if either input is unsigned. Possible a fix for #128895. Co-authored-by: Copilot <[email protected]>
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Jun 3, 2026
This was referenced Jun 4, 2026
JulieLeeMSFT
added
Servicing-approved
Member
|
@AndyAyersMS, please check test failures. |
Member
|
Failure was a dead-letter on one OSX test leg. Going to rerun it. |
Member
|
/ba-g all known issues. |
|
@JulieLeeMSFT or @AndyAyersMS : Will this be included in the 10.0.10 servicing patch this july? |
Member
|
Yes it is part of 10.0.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #128928 to release/10.0
/cc @AndyAyersMS
Customer Impact
Reported in #128895. Impacts a shipping app.
Regression
Regression from .NET 8/9 (though the introducing change #78786 was also in .NET 8, but apparently not easily reachable).
Testing
Created independent repro based on customer's report. Developed fix and shared with customer, who validated it on their app. Local testing (SPMI, etc) revealed no diffs.
Risk
Low. Disables an optimization.