Repository navigation
Disable a dozen more CG2 compDoOldStructRetyping assert failures - #38249
Merged
Merged
Conversation
Disable more tests failing on Windows ARM64 with the bug dotnet#37883 (compDoOldStructRetyping assertion failure in JIT). I think this is currently the biggest known error bucket in CG2 composite testing. Thanks Tomas
sandreenko
approved these changes
Jun 23, 2020
sandreenko
left a comment
sandreenko
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks, I will look at the issue shortly.
Contributor
|
Wouldn't it be easier to disable all of them with <ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/Arm/AdvSimd/**">? |
AntonLapounov
approved these changes
Jun 23, 2020
Member
Author
|
@AntonLapounov - I was also thinking about bulk-disabling the entire subfolder but I think there is some value in having a precise list of the failing test apps in the issues.targets file, at the very least because it makes the size of the file roughly proportional to the number of failures. My biggest hope is that we're going to be able to delete this list soon. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable more tests failing on Windows ARM64 with the bug
#37883
(compDoOldStructRetyping assertion failure in JIT). I think
this is currently the biggest known error bucket in CG2 composite
testing.
Thanks
Tomas
/cc: @dotnet/crossgen-contrib; @dotnet/jit-contrib