Skip to content

Enable Hot Reload API on Linux - #48497

Merged
mikem8361 merged 8 commits into
dotnet:masterfrom
mikem8361:linuxhotreload
Feb 20, 2021
Merged

mikem8361 merged 8 commits into
dotnet:masterfrom
mikem8361:linuxhotreload

Conversation

@mikem8361

Copy link
Copy Markdown
Contributor

Only define EnC_SUPPORTED for vm/ee on xplat. Doesn't enable the ENC ICorDebug API.

This is mostly build stuff with a couple of code changes to build code on Linux/MacOS.

Enable hotreload api tests on Linux/MacOS

@mikem8361 mikem8361 added this to the 6.0.0 milestone Feb 19, 2021
@mikem8361 mikem8361 self-assigned this Feb 19, 2021
@ghost ghost added the area-VM-coreclr label Feb 19, 2021
Comment thread src/coreclr/clrdefinitions.cmake Outdated
Comment thread src/coreclr/vm/encee.cpp Outdated
@jkotas

jkotas commented Feb 19, 2021

Copy link
Copy Markdown
Member

LGTM otherwise.

@jkotas

jkotas commented Feb 19, 2021

Copy link
Copy Markdown
Member

Could you please also delete the EnC hack code from src/coreclr/ilasm/* ? Delete writer_enc.cpp file, m_fENCMode, InitMetaDataForENC and friends, CreateDeltaFiles, COMP_ENC_OPENSCOPE, COMP_ENC_EMIT.

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread src/libraries/System.Runtime.Loader/tests/AssemblyExtensionsTest.cs Outdated
@mikem8361
mikem8361 merged commit f30a718 into dotnet:master Feb 20, 2021
@mikem8361
mikem8361 deleted the linuxhotreload branch February 20, 2021 21:51
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants