Repository navigation
Remove compiler warning suppression - #66234
Merged
AaronRobinsonMSFT merged 10 commits intoMar 9, 2022
Merged
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsContributes to #66154 @janvorli or @am11 - there are updates to the libuwind source. I was planning on submitting a PR to https://github.com/libunwind/libunwind, is that appropriate?
|
AaronRobinsonMSFT
force-pushed
the
address_warnings
branch
from
March 5, 2022 03:46
aa7ed7e to
6e1f87b
Compare
am11
reviewed
Mar 5, 2022
AaronRobinsonMSFT
marked this pull request as ready for review
March 5, 2022 14:49
Member
Please add a line (it helps when revving libunwind version) |
21 tasks done
Member
|
@AaronRobinsonMSFT debugger changes LGTM |
Member
Author
jkotas
reviewed
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #66154
All changes, except warning 4267, impact both mono and coreclr. Warning 4267 is extensive in mono and will require more effort to address.
@janvorli or @am11 - there are updates to the libunwind source. I was planning on submitting a PR to https://github.com/libunwind/libunwind, is that appropriate?Upstream PR: libunwind/libunwind#333
/cc @GrabYourPitchforks