Repository navigation
[wasm] Process WebSocket connection errors on NodeJS - #69858
Merged
Merged
Conversation
|
Tagging subscribers to this area: @directhex Issue DetailsSome of the errors produced during WebSocket connection are published as "error" event.
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failures are not relevant. |
pavelsavara
approved these changes
May 30, 2022
This was referenced Jun 28, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the errors produced during WebSocket connection are published as "error" event.
Here we attach a listener to it and reject the open promise if the event is raised (which correctly produces an exception in managed code).
Fixes #63671.
Fixes #63681.