Repository navigation
[Mono] Fix C4018 warnings round II - #70783
Merged
Merged
Conversation
fanyang-mono
requested review from
BrzVlad,
SamMonoRT,
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
June 15, 2022 16:23
ghost
assigned
lambdageek
reviewed
Jun 17, 2022
lambdageek
reviewed
Jun 17, 2022
lambdageek
approved these changes
Jun 20, 2022
lambdageek
left a comment
lambdageek
left a comment
Member
There was a problem hiding this comment.
lgtm. please also update the definition of upd_locator_t in hot_reload.c - it needs to stay in sync with locator_t
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failures on CI are not related to this PR. They were seen on rolling build as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second portion of fixing C4018 warnings on Mono runtime x86/x64 Windows build, aligning with SDL requirements (#66154).