Skip to content

[wasm][aot] Avoid making the 'this' variable volatile. - #71799

Merged
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:wasm-no-this-volatile
Jul 14, 2022
Merged

vargaz merged 1 commit into
dotnet:mainfrom
vargaz:wasm-no-this-volatile

Conversation

@vargaz

@vargaz vargaz commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

This is only needed in non-llvmonly mode for computing stack traces in gshared methods.

@vargaz
vargaz removed the request for review from SamMonoRT July 8, 2022 00:42
@ghost ghost added the area-Codegen-AOT-mono label Jul 8, 2022
@ghost ghost assigned vargaz Jul 8, 2022
@vargaz

vargaz commented Jul 8, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing

lewing commented Jul 11, 2022

Copy link
Copy Markdown
Member

/azp run runtime

@lewing

lewing commented Jul 11, 2022

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This is only needed in non-llvmonly mode for computing stack traces in gshared methods.
@vargaz
vargaz force-pushed the wasm-no-this-volatile branch from 022b87a to 0456082 Compare July 13, 2022 15:40
@vargaz

vargaz commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
vargaz merged commit 45432c5 into dotnet:main Jul 14, 2022
@vargaz
vargaz deleted the wasm-no-this-volatile branch July 14, 2022 05:57
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants