Skip to content

Move all of generic virtual method resolution to the type loader - #79925

Merged
jkotas merged 2 commits into
dotnet:mainfrom
MichalStrehovsky:moveresolve
Dec 23, 2022
Merged

jkotas merged 2 commits into
dotnet:mainfrom
MichalStrehovsky:moveresolve

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

For whatever reason, the logic that walks the inheritance hierarchy and deals with the differences between interface GVM and class GVM calls was in CoreLib.

Move it to the type loader because we'll need it for #77070.

This is just a mechanical change - copy paste the code to the new location and adapt so that it builds.

Cc @dotnet/ilc-contrib

For whatever reason, the logic that walks the inheritance hierarchy and deals with the differences between interface GVM and class GVM calls was in CoreLib.

Move it to the type loader because we'll need it for dotnet#77070.
@ghost

ghost commented Dec 23, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

For whatever reason, the logic that walks the inheritance hierarchy and deals with the differences between interface GVM and class GVM calls was in CoreLib.

Move it to the type loader because we'll need it for #77070.

This is just a mechanical change - copy paste the code to the new location and adapt so that it builds.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas
jkotas merged commit 5b99dce into dotnet:main Dec 23, 2022
@MichalStrehovsky
MichalStrehovsky deleted the moveresolve branch December 25, 2022 05:05
@ghost ghost locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants