Repository navigation
Delete JIT disasm output in test wrappers before running FileCheck - #81538
Merged
Merged
Conversation
JitStdOutFile has append behavior, so if you rerun the scripts you would get multiple repeated sets of jitdisasm. This would give FileCheck a much range of disassembly to match that was much wider than expected.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsJitStdOutFile has append behavior, so if you rerun the scripts you would get multiple repeated sets of jitdisasm. This would give FileCheck a much range of disassembly to match that was much wider than expected.
|
Contributor
|
This has been bothering me for a while! Glad to see a fix. Was going to do myself but hadn't tracked down where to do the delete. |
TIHan
approved these changes
Feb 2, 2023
This was referenced Feb 2, 2023
markples
approved these changes
Feb 2, 2023
Member
Author
|
Failures are known according to build analysis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JitStdOutFile has append behavior, so if you rerun the scripts you would get multiple repeated sets of jitdisasm. This would give FileCheck a range of disassembly to match that was much wider than expected.