Skip to content

Fix more bugs found with ILVerify - #98393

Merged
buyaa-n merged 3 commits into
dotnet:mainfrom
buyaa-n:fix-bug
Feb 14, 2024
Merged

buyaa-n merged 3 commits into
dotnet:mainfrom
buyaa-n:fix-bug

Conversation

@buyaa-n

@buyaa-n buyaa-n commented Feb 13, 2024

Copy link
Copy Markdown
Contributor
  • For constructors populated from constructed generic type also need to load original ctor version
  • Incorrect token when unbaked TypeBuilder used as generic argument for generic method
  • Add MethodBuilderImpl.ReturnParameter implementation

Contributes to #92975

@ghost

ghost commented Feb 13, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details
  • For constructors populated from constructed generic type also need to load original ctor version
  • Incorrect token when unbaked TypeBuilder used as generic argument for generic method
  • Add MethodBuilderImpl.ReturnParameter implementation

Contributes to #92975

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection.Emit

Milestone: -

…icParameters, check generic parameters instead, add related test

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@buyaa-n
buyaa-n requested a review from marek-safar as a code owner February 14, 2024 19:11
@buyaa-n
buyaa-n merged commit 72ee969 into dotnet:main Feb 14, 2024
@buyaa-n
buyaa-n deleted the fix-bug branch February 14, 2024 22:13
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants