Repository navigation
[webassembly/pyscript] Add mip - #19
Closed
JeffersGlass wants to merge 0 commit into
Closed
JeffersGlass wants to merge 0 commit into
JeffersGlass wants to merge 0 commit into
Conversation
|
I'd love to have this ported and tested in polyscript |
dpgeorge
force-pushed
the
webassembly-add-modjs
branch
from
December 13, 2023 05:30
45b9d98 to
60165e3
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
mippackage to work in the webassembly/PyScript port of Micropython, by re-implementing theurequestsusing browser APIs.What this PR is missing is tests. Without an automated in-the-browser testing setup (e.g. Playwright, Puppeteers, etc), I'm not sure what the appropriate method of including them is. A static HTML file as a 'smoke test' is possible, but likely not ideal.
While it would be nice for this PR to live in the Micropython port itself, I could also see this as an argument for incorporating it downstream in Polyscript, where the testing story in the browser is more present. Perhaps @WebReflection has an opinion there.