Skip to content

chore: remove upstreamed Node.js patches - #52694

Merged
dsanders11 merged 1 commit into
electron:mainfrom
Archkon:cleanpatch
Aug 9, 2026
Merged

chore: remove upstreamed Node.js patches#52694
dsanders11 merged 1 commit into
electron:mainfrom
Archkon:cleanpatch

Conversation

@Archkon

@Archkon Archkon commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of Change

Node.js now enables Float16Array on the global object and includes in builtin_info.cc. The corresponding Electron patches are therefore no-ops on Node.js v24.18.1.

Remove both patches and re-export the Node.js patch series.

Refs: nodejs/node#58154
Refs: nodejs/node#63001

Checklist

Release Notes

Notes: None

@Archkon
Archkon requested a review from a team as a code owner August 7, 2026 14:41
@welcome

welcome Bot commented Aug 7, 2026

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR contains unsigned commits. This repository enforces commit signatures
for all incoming PRs. To get your PR merged, please sign those commits
(git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch
(git push --force-with-lease)

For more information on signing commits, see GitHub's documentation on Telling Git about your signing key.

@github-actions github-actions Bot added the needs-signed-commits Currently some or all of the commits in this PR are not signed label Aug 7, 2026
jkleinsc
jkleinsc previously requested changes Aug 7, 2026
View reviewed changes

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @Archkon. We require signed commits, so please sign your commit so that we can proceed with this PR.

@Archkon
chore: remove upstreamed Node.js patches
8239937 
Node.js now enables Float16Array on the global object and includes
<cstdlib> in builtin_info.cc. The corresponding Electron patches are
therefore no-ops on Node.js v24.18.1.

Remove both patches and re-export the Node.js patch series.

Refs: nodejs/node#58154
Refs: nodejs/node#63001
@github-actions github-actions Bot removed the needs-signed-commits Currently some or all of the commits in this PR are not signed label Aug 7, 2026
@Archkon

Archkon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jkleinsc Sorry,I just don't notice that requirement

@Archkon
Archkon requested a review from jkleinsc August 7, 2026 17:28
@dsanders11 dsanders11 added semver/none target/44-x-y PR should also be added to the "44-x-y" branch. labels Aug 7, 2026
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 8, 2026
@dsanders11
dsanders11 dismissed jkleinsc’s stale review August 9, 2026 05:58

Stale, commits now signed

@dsanders11
dsanders11 merged commit 1f58b97 into electron:main Aug 9, 2026
95 checks passed
@welcome

welcome Bot commented Aug 9, 2026

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk

release-clerk Bot commented Aug 9, 2026

Copy link
Copy Markdown

No Release Notes

@github-actions github-actions Bot added the 45-x-y label Aug 9, 2026
@trop trop Bot mentioned this pull request Aug 9, 2026
Merged
@trop

trop Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "44-x-y", please check out #52728

@trop trop Bot added in-flight/44-x-y and removed target/44-x-y PR should also be added to the "44-x-y" branch. labels Aug 9, 2026
@Archkon
Archkon deleted the cleanpatch branch August 9, 2026 06:00
@trop trop Bot added merged/44-x-y PR was merged to the "44-x-y" branch. and removed in-flight/44-x-y labels Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes
@dsanders11 dsanders11 dsanders11 approved these changes
@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes
@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees

No one assigned

Labels

45-x-y merged/44-x-y PR was merged to the "44-x-y" branch. semver/none

Projects

45-x-y
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Archkon @ckerr @jkleinsc @dsanders11 @MarshallOfSound