Repository navigation
fix: return opaque responses from file and http protocol handlers for cross-origin no-cors requests - #52822
Merged
Conversation
… cross-origin no-cors requests The opaque tagging added for cross-origin no-cors loads is written to a local response head that only the string/buffer/stream sinks deliver. The file sink (asar/file loader) and the http sink (URLPipeLoader) build or forward their own response head, dropping the tag, so a cross-origin mode=no-cors fetch of a registerFileProtocol or registerHttpProtocol resource was delivered as a basic, script-readable response. Compute the opaque decision once in StartLoading and interpose a URLLoaderClient on the file and http sinks that re-applies the opaque tag to the head those sinks emit, matching the behaviour of the other sinks.
MarshallOfSound
added
semver/patch
codebytere
approved these changes
Aug 15, 2026
MarshallOfSound
enabled auto-merge (squash)
August 15, 2026 21:49
VerteDinde
approved these changes
Aug 15, 2026
|
Release Notes Persisted
|
This was referenced Aug 16, 2026
Contributor
|
I have automatically backported this PR to "44-x-y", please check out #52852 |
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #52853 |
trop
Bot
removed
the
target/44-x-y
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #52854 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #52855 |
trop
Bot
added
in-flight/43-x-y
in-flight/41-x-y
in-flight/42-x-y
and removed
target/43-x-y
trop
Bot
added
merged/43-x-y
deepak1556
reviewed
Aug 17, 2026
| filter->receiver_.Bind(proxy.InitWithNewPipeAndPassReceiver()); | ||
| filter->receiver_.set_disconnect_handler(base::BindOnce( | ||
| &OpaqueResponseFilter::DeleteThis, base::Unretained(filter))); | ||
| return proxy; |
Member
There was a problem hiding this comment.
Since this class is more of a proxy between URLLoaderClient remote and receiver. It would be good to also listen on destination disconnect so that the other end can early abort as well.
filter->destination_.set_disconnect_handler(base::BindOnce(
&OpaqueResponseFilter::DeleteThis, base::Unretained(filter)));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom schemes registered with
supportFetchAPI: truebut withoutcorsEnabled: trueshould return an opaque response to a cross-originfetch(url, { mode: 'no-cors' }), the same asprotocol.handle. The response was only tagged opaque on the string/buffer/stream path —registerFileProtocolandregisterHttpProtocoldelivered a readable (basic) response instead.ElectronURLLoaderFactory::StartLoadingand thread it into the file and http loaders.kOpaqueon the file and http paths via a smallURLLoaderClientinterposer, soasar, the plain file loader, andURLPipeLoaderall match the buffer/stream path.registerFileProtocolandregisterHttpProtocolcross-originno-corsfetches.Notes: Fixed
registerFileProtocolandregisterHttpProtocolreturning readable responses to cross-originno-corsfetches; they now return opaque responses likeprotocol.handle.