Repository navigation
fix: inherit nodeIntegrationInWorker from the embedder for <webview> and window.open - #52830
Merged
Conversation
…and window.open The list of security options a <webview> guest always inherits from its embedder, and the equivalent list child windows inherit from their parent, omitted nodeIntegrationInWorker. As a result the webpreferences attribute could set nodeIntegrationInWorker on a guest whose embedder had it disabled, giving the guest's dedicated workers a Node environment the embedder itself did not grant (and, with an unsandboxed embedder, dropping the guest out of the sandbox). Add nodeIntegrationInWorker to both inheritance lists so a guest can never be less secure than its embedder for this option. Co-authored-by: Sam Attard <[email protected]>
MarshallOfSound
approved these changes
Aug 15, 2026
trop
Bot
added
43-x-y
backport
MarshallOfSound
enabled auto-merge (squash)
August 15, 2026 23:06
MarshallOfSound
deleted the
trop/43-x-y-bp-fix-inherit-nodeintegrationinworker-from-the-embedder-for-webview-and-window-open-1786835147835
branch
August 16, 2026 00:34
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52823
See that PR for details.
Notes:
<webview>andwindow.opennow inheritnodeIntegrationInWorkerfrom the embedder, consistent with the other Node and sandbox preferences.